Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proper error handling for bip353 dns addresses from phoenix + self hosted dns addresses #3197

Merged
merged 1 commit into from
Jul 15, 2024
Merged

proper error handling for bip353 dns addresses from phoenix + self hosted dns addresses #3197

merged 1 commit into from
Jul 15, 2024

Conversation

pavanjoshi914
Copy link
Contributor

error handling

@bumi
Copy link
Collaborator

bumi commented Jul 15, 2024

can you share some screenshots?

@pavanjoshi914
Copy link
Contributor Author

  1. pheonix lnaddresses

image

  1. self hosted bip353 address or when invalid ln address entered
    image

@bumi bumi merged commit 9347f5c into master Jul 15, 2024
6 checks passed
@bumi bumi deleted the error-handle-bip353 branch July 15, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavanjoshi914 @bumi